From 14500953ed5a6ecbdc5842c9f86c557b1f6af5e1 Mon Sep 17 00:00:00 2001 From: Xavier Hallade Date: Tue, 21 Nov 2023 19:23:59 +0100 Subject: [PATCH] Overlay: Wireframe: avoid using custom depth bias with xray enabled e000dcb8490880d6d49aa91588c457612685e9f1 has a performance impact as it prevents early depth test, it's best to restrict it to when xray is disabled. Pull Request: https://projects.blender.org/blender/blender/pulls/114466 --- source/blender/draw/engines/overlay/overlay_wireframe.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/blender/draw/engines/overlay/overlay_wireframe.cc b/source/blender/draw/engines/overlay/overlay_wireframe.cc index b9b943fb5f1..014e94f1139 100644 --- a/source/blender/draw/engines/overlay/overlay_wireframe.cc +++ b/source/blender/draw/engines/overlay/overlay_wireframe.cc @@ -66,7 +66,8 @@ void OVERLAY_wireframe_cache_init(OVERLAY_Data *vedata) const bool use_select = (DRW_state_is_select() || DRW_state_is_depth()); GPUShader *wires_sh = use_select ? OVERLAY_shader_wireframe_select() : - OVERLAY_shader_wireframe(pd->antialiasing.enabled); + OVERLAY_shader_wireframe(pd->antialiasing.enabled && + !pd->xray_enabled); for (int xray = 0; xray < (is_material_shmode ? 1 : 2); xray++) { DRWState state = DRW_STATE_FIRST_VERTEX_CONVENTION | DRW_STATE_WRITE_COLOR |