dillongoostudios/goo-engine
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Despgraph: Rename "copy-on-write" to "copy-on-evaluation"

Browse Source 
The depsgraph CoW mechanism is a bit of a misnomer. It creates an
evaluated copy for data-blocks regardless of whether the copy will
actually be written to. The point is to have physical separation between
original and evaluated data. This is in contrast to the commonly used
performance improvement of keeping a user count and copying data
implicitly when it needs to be changed. In Blender code we call this
"implicit sharing" instead. Importantly, the dependency graph has no
idea about the _actual_ CoW behavior in Blender.

Renaming this functionality in the despgraph removes some of the
confusion that comes up when talking about this, and will hopefully
make the depsgraph less confusing to understand initially too. Wording
like "the evaluated copy" (as opposed to the original data-block) has
also become common anyway.

Pull Request: https://projects.blender.org/blender/blender/pulls/118338
This commit is contained in:
Hans Goudey
2024-02-19 15:54:08 +01:00
committed by Hans Goudey
parent 5a76a4190d
commit 81a63153d0
192 changed files with 789 additions and 786 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/creator/creator_args.cc
+8 -8
View File
@@ -1612,7 +1612,7 @@ static int arg_handle_output_set(int argc, const char **argv, void *data)
Scene *scene = CTX_data_scene(C);
if (scene) {
STRNCPY(scene->r.pic, argv[1]);
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
else {
fprintf(stderr, "\nError: no blend loaded. cannot use '-o / --render-output'.\n");
@@ -1643,7 +1643,7 @@ static int arg_handle_engine_set(int argc, const char **argv, void *data)
if (scene) {
if (BLI_findstring(&R_engines, argv[1], offsetof(RenderEngineType, idname))) {
STRNCPY_UTF8(scene->r.engine, argv[1]);
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
else {
fprintf(stderr, "\nError: engine not found '%s'\n", argv[1]);
@@ -1687,7 +1687,7 @@ static int arg_handle_image_type_set(int argc, const char **argv, void *data)
}
else {
scene->r.im_format.imtype = imtype_new;
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
}
else {
@@ -1772,11 +1772,11 @@ static int arg_handle_extension_set(int argc, const char **argv, void *data)
if (scene) {
if (argv[1][0] == '0') {
scene->r.scemode &= ~R_EXTENSION;
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
else if (argv[1][0] == '1') {
scene->r.scemode |= R_EXTENSION;
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
else {
fprintf(stderr,
@@ -1928,7 +1928,7 @@ static int arg_handle_frame_start_set(int argc, const char **argv, void *data)
fprintf(stderr, "\nError: %s '%s %s'.\n", err_msg, arg_id, argv[1]);
}
else {
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
return 1;
}
@@ -1962,7 +1962,7 @@ static int arg_handle_frame_end_set(int argc, const char **argv, void *data)
fprintf(stderr, "\nError: %s '%s %s'.\n", err_msg, arg_id, argv[1]);
}
else {
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
return 1;
}
@@ -1988,7 +1988,7 @@ static int arg_handle_frame_skip_set(int argc, const char **argv, void *data)
fprintf(stderr, "\nError: %s '%s %s'.\n", err_msg, arg_id, argv[1]);
}
else {
DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&scene->id, ID_RECALC_SYNC_TO_EVAL);
}
return 1;
}