From f1d436a3aa7e75cfe362ee462da0bdaa9652d2fa Mon Sep 17 00:00:00 2001 From: Colin Basnett Date: Wed, 17 May 2023 05:02:39 +0200 Subject: [PATCH] Core: Improve error message for make relative/make absolute operators This improves the warning messages when make relative/absolute fails to add more context and help in tracking down problems. Pull Request: https://projects.blender.org/blender/blender/pulls/107914 --- source/blender/blenkernel/intern/bpath.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/source/blender/blenkernel/intern/bpath.c b/source/blender/blenkernel/intern/bpath.c index 400e9174764..47841965c55 100644 --- a/source/blender/blenkernel/intern/bpath.c +++ b/source/blender/blenkernel/intern/bpath.c @@ -513,7 +513,14 @@ static bool relative_convert_foreach_path_cb(BPathForeachPathData *bpath_data, data->count_changed++; } else { - BKE_reportf(data->reports, RPT_WARNING, "Path '%s' cannot be made relative", path_src); + const char *type_name = BKE_idtype_get_info_from_id(bpath_data->owner_id)->name; + const char *id_name = bpath_data->owner_id->name + 2; + BKE_reportf(data->reports, + RPT_WARNING, + "Path '%s' cannot be made relative for %s '%s'", + path_src, + type_name, + id_name); data->count_failed++; } return true; @@ -537,7 +544,14 @@ static bool absolute_convert_foreach_path_cb(BPathForeachPathData *bpath_data, data->count_changed++; } else { - BKE_reportf(data->reports, RPT_WARNING, "Path '%s' cannot be made absolute", path_src); + const char *type_name = BKE_idtype_get_info_from_id(bpath_data->owner_id)->name; + const char *id_name = bpath_data->owner_id->name + 2; + BKE_reportf(data->reports, + RPT_WARNING, + "Path '%s' cannot be made absolute for %s '%s'", + path_src, + type_name, + id_name); data->count_failed++; } return true;