dillongoostudios/goo-engine
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
cbc33871c6f66150342f7fd34ad463566f9784fd
goo-engine/source/blender/blenkernel
T
History
Sean Kim cbc33871c6 Fix #129425: Using Voxel Remesh in sculpt mode can crash 
When using the Voxel Remesh operator, there are two possible sources of
crashes currently:
* TBB task stealing in nested parallel loops with thread local data
* Null dereference of PBVH data when pushing sculpt undo steps

To fix the former issue, this commit guards the
`threading::parallel_for` internal function with
`threading::isolate_task` to prevent possible task stealing and
corruption of the thread local data.

Additionally, it has the effect of fixing debug asserts inside
`array_utils::gather` due to the this task stealing.

To fix the latter issue, this commit adds a call to
`BKE_sculpt_update_object_for_edit` to ensure that this data is
populated.

Original PR: !129704

Pull Request: https://projects.blender.org/blender/blender/pulls/129823
2024-11-13 15:19:05 +01:00
..
intern
Fix #129425: Using Voxel Remesh in sculpt mode can crash
2024-11-13 15:19:05 +01:00
BKE_action.h
…
BKE_action.hh
…
BKE_addon.h
Cleanup: use const arguments & variables
2024-04-04 10:55:10 +11:00
BKE_anim_data.hh
Cleanup: doxygen syntax, use colons after "param" arguments, not "note"
2024-04-24 10:55:44 +10:00
BKE_anim_path.h
…
BKE_anim_visualization.h
…
BKE_animsys.h
Fix #119946: NLA stack decomposition doesn't work with bones
2024-03-28 15:14:01 +01:00
BKE_anonymous_attribute_id.hh
…
BKE_appdir.hh
Docs: clarification for BKE_appdir.hh folder_id
2024-06-07 11:46:40 +10:00
BKE_armature.hh
Cleanup: spelling in code comments & minor edits
2024-06-06 09:55:13 +10:00
BKE_asset.hh
Nodes: add node group description
2024-05-08 11:25:00 +02:00
BKE_attribute_math.hh
…
BKE_attribute.h
Attributes: support setting the active attribute to "None"
2024-11-12 13:30:05 +01:00
BKE_attribute.hh
Cleanup: Avoid unnecessary copies of VArray
2024-05-07 04:02:17 +02:00
BKE_autoexec.hh
…
BKE_bake_data_block_id.hh
…
BKE_bake_data_block_map.hh
…
BKE_bake_geometry_nodes_modifier.hh
…
BKE_bake_items_paths.hh
…
BKE_bake_items_serialize.hh
Libraries: integrate xxHash library for fast hashing
2024-04-03 10:22:53 +02:00
BKE_bake_items_socket.hh
…
BKE_bake_items.hh
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_blender_cli_command.hh
…
BKE_blender_copybuffer.hh
…
BKE_blender_undo.hh
…
BKE_blender_user_menu.hh
…
BKE_blender_version.h
Fix #126728: Movie Clip Editor "Sync Visible Range" option not working
2024-11-12 16:04:06 +01:00
BKE_blender.hh
…
BKE_blendfile_link_append.hh
Fix (unreported) crash when linking data from other endianness files.
2024-05-10 16:00:30 +02:00
BKE_blendfile.hh
…
BKE_boids.h
…
BKE_bpath.hh
…
BKE_brush.hh
Cleanup: Sculpt: Use const and references
2024-05-20 02:56:25 +02:00
BKE_bvhutils.hh
Fix #127964: Crash when baking from mesh with no faces
2024-10-10 11:21:16 +02:00
BKE_cachefile.hh
…
BKE_callbacks.hh
Extensions: remove intermediate operators for upgrade and sync
2024-06-07 16:33:03 +10:00
BKE_camera.h
…
BKE_ccg.hh
Cleanup: Use C++ types, references for CCGElem access
2024-06-02 20:36:33 -04:00
BKE_cloth.hh
…
BKE_collection.hh
Node Tools: Avoid depsgraph evaluation when possible
2024-04-24 17:08:25 +02:00
BKE_collision.h
…
BKE_colorband.hh
…
BKE_colortools.hh
…
BKE_compute_contexts.hh
Refactor: Move node tools OperatorComputeContext to blenkernel
2024-04-12 16:16:55 -04:00
BKE_constraint.h
…
BKE_context.hh
UI: Allow passing named strings via context
2024-05-27 18:46:19 +02:00
BKE_cpp_types.hh
…
BKE_crazyspace.hh
…
BKE_cryptomatte.h
Fix #125232: EEVEE writes wrong Cryptomatte meta data
2024-08-06 19:04:22 +02:00
BKE_cryptomatte.hh
…
BKE_curve_legacy_convert.hh
…
BKE_curve_to_mesh.hh
…
BKE_curve.hh
Cleanup: Use const for edit mesh deformation arguments
2024-05-20 10:14:41 -04:00
BKE_curveprofile.h
…
BKE_curves_utils.hh
…
BKE_curves.h
…
BKE_curves.hh
Curve: reduce overhead in debug builds
2024-06-19 12:08:27 +02:00
BKE_customdata_file.h
Cleanup: use const pointer arguments
2024-03-28 20:57:50 +11:00
BKE_customdata.hh
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_data_transfer.h
…
BKE_deform.hh
Cleanup: Use forward declaration headers in a few places
2024-03-27 22:25:08 -04:00
BKE_displist.h
…
BKE_duplilist.hh
…
BKE_dynamicpaint.h
…
BKE_editlattice.h
…
BKE_editmesh_bvh.hh
Cleanup: pass const arguments to BMBVHTree related functions
2024-10-10 10:29:29 +02:00
BKE_editmesh_cache.hh
Cleanup: Improve EditMeshData comments
2024-04-02 21:11:34 -04:00
BKE_editmesh_tangent.hh
Cleanup: Use C++ types for various mesh array arguments
2024-05-20 02:58:13 +02:00
BKE_editmesh.hh
Cleanup: Add comment about edit mesh BMesh ownership
2024-05-20 10:00:31 -04:00
BKE_effect.h
Fix: Memory leak and race condition with particle effector RNG
2024-03-27 18:06:31 +01:00
BKE_fcurve_driver.h
…
BKE_fcurve.hh
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_file_handler.hh
Collection Exporters: Enable file exporters to be specified on Collections
2024-04-08 22:10:39 +02:00
BKE_fluid.h
…
BKE_freestyle.h
…
BKE_geometry_fields.hh
Geometry Nodes: support capturing multiple attributes at once
2024-05-31 16:23:31 +02:00
BKE_geometry_set_instances.hh
…
BKE_geometry_set.hh
…
BKE_global.hh
Preference: add option allow internet access
2024-05-23 13:50:06 +10:00
BKE_gpencil_curve_legacy.h
…
BKE_gpencil_geom_legacy.h
…
BKE_gpencil_legacy.h
…
BKE_gpencil_modifier_legacy.h
…
BKE_gpencil_update_cache_legacy.h
…
BKE_grease_pencil_legacy_convert.hh
Cleanup: GPv3 conversion: Remove unused public functions.
2024-04-16 18:01:15 +02:00
BKE_grease_pencil_vertex_groups.hh
GPv3: Weight Paint tools (Draw, Blur, Average, Smear, Sample weight)
2024-04-25 15:21:14 +02:00
BKE_grease_pencil.h
…
BKE_grease_pencil.hh
GPv3: Lock material layer property
2024-05-31 15:13:35 +02:00
BKE_icons.h
…
BKE_idprop.hh
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_idtype.hh
Core: IDManagement: Refactor how 'never unused' IDs are defined.
2024-05-24 17:43:22 +02:00
BKE_image_format.h
…
BKE_image_partial_update.hh
…
BKE_image_save.h
…
BKE_image_wrappers.hh
…
BKE_image.h
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_instances.hh
…
BKE_ipo.h
…
BKE_kelvinlet.h
…
BKE_key.hh
…
BKE_keyconfig.h
…
BKE_lattice.hh
Cleanup: Use const for edit mesh deformation arguments
2024-05-20 10:14:41 -04:00
BKE_layer.hh
Fix crash applying object transform for multi-user objects
2024-10-10 10:01:17 +02:00
BKE_lib_id.hh
BKE_lib: avoid potential read uninitialized memory in BKE_id_copy_*
2024-09-23 13:18:21 +02:00
BKE_lib_override.hh
…
BKE_lib_query.hh
Cleanup: spelling in code comments & minor edits
2024-06-06 09:55:13 +10:00
BKE_lib_remap.hh
…
BKE_library.hh
…
BKE_light_linking.h
…
BKE_light.h
…
BKE_lightprobe.h
…
BKE_linestyle.h
Cleanup: use const pointer arguments
2024-04-03 10:22:05 +11:00
BKE_main_idmap.hh
…
BKE_main_namemap.hh
…
BKE_main.hh
Anim: merge Animation data-block into bAction
2024-05-13 15:58:04 +02:00
BKE_mask.h
Cleanup: use const pointer arguments
2024-04-03 10:22:05 +11:00
BKE_material.h
Fix #125353: Select by active material fails to select the active slot
2024-08-06 19:04:28 +02:00
BKE_mball_tessellate.hh
…
BKE_mball.hh
…
BKE_mesh_compare.hh
…
BKE_mesh_fair.hh
…
BKE_mesh_iterators.hh
…
BKE_mesh_legacy_convert.hh
…
BKE_mesh_legacy_derived_mesh.hh
Cleanup: Rename DerivedMesh.cc and header
2024-05-20 13:11:18 -04:00
BKE_mesh_mapping.hh
Cleanup: code-comments, use doxygen formatting & spelling corrections
2024-03-26 17:55:20 +11:00
BKE_mesh_mirror.hh
…
BKE_mesh_remap.hh
…
BKE_mesh_remesh_voxel.hh
…
BKE_mesh_runtime.hh
Cleanup: Move mesh evaluation functions to C++ namespace
2024-05-20 13:11:18 -04:00
BKE_mesh_sample.hh
…
BKE_mesh_tangent.hh
Cleanup: Use C++ types for various mesh array arguments
2024-05-20 02:58:13 +02:00
BKE_mesh_types.hh
Mesh: Store BMEditMesh in shared pointer
2024-04-18 13:52:20 +02:00
BKE_mesh_wrapper.hh
Mesh: Store BMEditMesh in shared pointer
2024-04-18 13:52:20 +02:00
BKE_mesh.h
Cleanup: Use reference argument for BKE_mesh_copy_for_eval
2024-05-20 13:18:24 -04:00
BKE_mesh.hh
Sculpt: Add increase / decrease visibility operator
2024-05-28 17:12:45 +02:00
BKE_modifier.hh
Cleanup: Use const for edit mesh deformation arguments
2024-05-20 10:14:41 -04:00
BKE_movieclip.h
Cleanup: use const pointer arguments
2024-04-03 10:22:05 +11:00
BKE_multires.hh
Cleanup: Use const in some modifier related functions
2024-04-30 16:02:08 -04:00
BKE_nla.h
Cleanup: doxygen syntax, use colons after "param" arguments, not "note"
2024-04-24 10:55:44 +10:00
BKE_node_enum.hh
Geometry Nodes: show correct type in menu socket tooltips
2024-05-05 09:30:02 +02:00
BKE_node_runtime.hh
Cleanup: spelling in code comments & minor edits
2024-06-06 09:55:13 +10:00
BKE_node_socket_value.hh
Geometry Nodes: support volume grid sockets in bake node
2024-04-23 18:56:41 +02:00
BKE_node_tree_anonymous_attributes.hh
…
BKE_node_tree_dot_export.hh
…
BKE_node_tree_interface.hh
Cleanup: use uppercase tags, following own style guide
2024-05-03 11:33:21 +10:00
BKE_node_tree_update.hh
…
BKE_node_tree_zones.hh
…
BKE_node.hh
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_object_deform.h
…
BKE_object_types.hh
…
BKE_object.hh
Docs: remove references to "above" in code comments & corrections
2024-06-23 12:14:19 +10:00
BKE_ocean.h
…
BKE_outliner_treehash.hh
…
BKE_packedFile.h
Cleanup: use const pointer arguments
2024-04-03 10:22:05 +11:00
BKE_paint.hh
Cleanup: Remove redundant prefixes in sculpt_boundary.cc
2024-06-04 14:22:13 -04:00
BKE_particle.h
Cleanup: Use const in some modifier related functions
2024-04-30 16:02:08 -04:00
BKE_pbvh_api.hh
Cleanup: Use C++ types, references for CCGElem access
2024-06-02 20:36:33 -04:00
BKE_pbvh_pixels.hh
…
BKE_pbvh.hh
Cleanup: Use references for sculpt PBVH variables
2024-04-29 22:21:23 +02:00
BKE_pointcache.h
Cleanup: match function/declaration names
2024-04-17 11:36:36 +10:00
BKE_pointcloud.hh
…
BKE_pose_backup.h
…
BKE_preferences.h
Extensions: add a Python API for user editable extension directories
2024-06-26 14:23:17 +10:00
BKE_preview_image.hh
Refactor: Move preview image runtime data to runtime struct
2024-05-20 15:24:03 +02:00
BKE_report.hh
Cleanup: doxygen syntax, use colons after "param" arguments, not "note"
2024-04-24 10:55:44 +10:00
BKE_rigidbody.h
…
BKE_scene_runtime.hh
Fix #119211: Masks do not update in GPU compositor
2024-06-13 07:43:11 +02:00
BKE_scene.hh
Cleanup: rename "name" to "filepath" for full paths
2024-03-28 20:57:50 +11:00
BKE_screen.hh
Fix #128012: disabling "Load UI" makes nodes unselectable
2024-10-10 10:48:05 +02:00
BKE_sequencer_offscreen.h
…
BKE_shader_fx.h
…
BKE_shrinkwrap.hh
Fix #120051: Crash when using shrinkwrap with Target Normal Project
2024-03-29 11:43:15 +01:00
BKE_softbody.h
…
BKE_sound.h
…
BKE_speaker.h
…
BKE_studiolight.h
…
BKE_subdiv_ccg.hh
Cleanup: Move mesh evaluation functions to C++ namespace
2024-05-20 13:11:18 -04:00
BKE_subdiv_deform.hh
Subdiv: Move most blenkernel subdiv code to C++ namespace
2024-04-19 09:03:31 -04:00
BKE_subdiv_eval.hh
Subdiv: Move most blenkernel subdiv code to C++ namespace
2024-04-19 09:03:31 -04:00
BKE_subdiv_foreach.hh
Subdiv: Move most blenkernel subdiv code to C++ namespace
2024-04-19 09:03:31 -04:00
BKE_subdiv_mesh.hh
Cleanup: Use C++ types, return values for loose edge subdivision
2024-05-20 23:07:14 -04:00
BKE_subdiv_modifier.hh
Subdiv: Move most blenkernel subdiv code to C++ namespace
2024-04-19 09:03:31 -04:00
BKE_subdiv_topology.hh
Subdiv: Move most blenkernel subdiv code to C++ namespace
2024-04-19 09:03:31 -04:00
BKE_subdiv.hh
Subdiv: Make OpenSubdiv_TopologyRefiner into a C++ class
2024-04-19 09:03:48 -04:00
BKE_subsurf.hh
Cleanup: Rename DerivedMesh.cc and header
2024-05-20 13:11:18 -04:00
BKE_text_suggestions.h
…
BKE_text.h
Cleanup: use const pointer arguments
2024-04-03 10:22:05 +11:00
BKE_texture.h
…
BKE_tracking.h
Cleanup: Use const for evaluated cage meshes and related data
2024-03-28 18:57:57 -04:00
BKE_type_conversions.hh
…
BKE_undo_system.hh
…
BKE_unit.hh
UI: Add Wavelength unit for scene-independent nanometer-scale inputs
2024-04-22 13:10:16 +02:00
BKE_vfont.hh
Cleanup: declare arrays as const where possible
2024-03-28 22:57:57 +11:00
BKE_vfontdata.hh
…
BKE_viewer_path.hh
…
BKE_volume_enums.hh
…
BKE_volume_grid_file_cache.hh
…
BKE_volume_grid_fwd.hh
…
BKE_volume_grid_type_traits.hh
…
BKE_volume_grid.hh
…
BKE_volume_openvdb.hh
…
BKE_volume_render.hh
…
BKE_volume_to_mesh.hh
…
BKE_volume.hh
…
BKE_wm_runtime.hh
…
BKE_workspace.hh
Cleanup: Miscellaneous cleanups to workspace status items
2024-05-06 18:20:43 -04:00
BKE_world.h
…
BKE_writeffmpeg.hh
…
BKE_writemovie.hh
…
CMakeLists.txt
Cleanup: use blender::float3 for BKE_bmbvh_* API
2024-10-10 10:19:36 +02:00
nla_private.h
Cleanup: code-comments, use doxygen formatting & spelling corrections
2024-03-26 17:55:20 +11:00
particle_private.h
…
tracking_private.h
…