Fix Cycles Metal AMD crash with shadow caustics, by disabling it

Better to disable than crashing, as we are not expecting a quick fix. The cause
is likely similar to issues with the light tree, which was already disabled.

Ref #104013

intern/cycles/device/device.cpp

@@ -359,6 +359,7 @@ DeviceInfo Device::get_multi_device(const vector<DeviceInfo> &subdevices,
 
   info.has_nanovdb = true;
   info.has_light_tree = true;
+  info.has_mnee = true;
   info.has_osl = true;
   info.has_guiding = true;
   info.has_profiling = true;
@@ -408,6 +409,7 @@ DeviceInfo Device::get_multi_device(const vector<DeviceInfo> &subdevices,
     /* Accumulate device info. */
     info.has_nanovdb &= device.has_nanovdb;
     info.has_light_tree &= device.has_light_tree;
+    info.has_mnee &= device.has_mnee;
     info.has_osl &= device.has_osl;
     info.has_guiding &= device.has_guiding;
     info.has_profiling &= device.has_profiling;

intern/cycles/device/device.h

@@ -75,6 +75,7 @@ class DeviceInfo {
   bool display_device;          /* GPU is used as a display device. */
   bool has_nanovdb;             /* Support NanoVDB volumes. */
   bool has_light_tree;          /* Support light tree. */
+  bool has_mnee;                /* Support MNEE. */
   bool has_osl;                 /* Support Open Shading Language. */
   bool has_guiding;             /* Support path guiding. */
   bool has_profiling;           /* Supports runtime collection of profiling info. */
@@ -97,6 +98,7 @@ class DeviceInfo {
     display_device = false;
     has_nanovdb = false;
     has_light_tree = true;
+    has_mnee = true;
     has_osl = false;
     has_guiding = false;
     has_profiling = false;

intern/cycles/device/hip/device.cpp

@@ -155,6 +155,7 @@ void device_hip_info(vector<DeviceInfo> &devices)
 
     info.has_nanovdb = true;
     info.has_light_tree = true;
+    info.has_mnee = true;
     info.denoisers = 0;
 
     info.has_gpu_queue = true;

intern/cycles/device/metal/device.mm

@@ -59,6 +59,7 @@ void device_metal_info(vector<DeviceInfo> &devices)
 
     info.has_nanovdb = vendor == METAL_GPU_APPLE;
     info.has_light_tree = vendor != METAL_GPU_AMD;
+    info.has_mnee = vendor != METAL_GPU_AMD;
 
     info.use_hardware_raytracing = vendor != METAL_GPU_INTEL;
     if (info.use_hardware_raytracing) {

intern/cycles/kernel/types.h

@@ -79,11 +79,6 @@ CCL_NAMESPACE_BEGIN
 #define __VISIBILITY_FLAG__
 #define __VOLUME__
 
-/* TODO: solve internal compiler perf issue and enable light tree on Metal/AMD. */
-#if defined(__KERNEL_METAL_AMD__)
-#  undef __LIGHT_TREE__
-#endif
-
 /* Device specific features */
 #ifdef WITH_OSL
 #  define __OSL__
@@ -105,6 +100,13 @@ CCL_NAMESPACE_BEGIN
 #  define __MNEE__
 #endif
 
+#if defined(__KERNEL_METAL_AMD__)
+/* Disabled due to internal compiler perf issue and enable light tree on Metal/AMD. */
+#  undef __LIGHT_TREE__
+/* Disabled due to compiler crash on Metal/AMD. */
+#  undef __MNEE__
+#endif
+
 /* Scene-based selective features compilation. */
 #ifdef __KERNEL_FEATURES__
 #  if !(__KERNEL_FEATURES & KERNEL_FEATURE_OBJECT_MOTION)