dillongoostudios/goo-engine
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix (unreported) memory leak in Nodes versioning code.

Browse Source 
Commit e071288ab2 do_version code was copying an allocated string from
old to new socket data, but not freeing it in the old data properly.

String can actually be moved directly from old to new data, instead of
duplicating it.
This commit is contained in:
Bastien Montagne
2023-09-01 19:31:39 +02:00
parent bfdfde18e1
commit 1bcd812a75
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/blender/blenloader/intern/versioning_400.cc
+7 -5
View File
@@ -605,15 +605,17 @@ static bNodeTreeInterfaceItem *legacy_socket_move_to_interface(bNodeSocket &lega
legacy_socket.flag & SOCK_HIDE_IN_MODIFIER,
NODE_INTERFACE_SOCKET_HIDE_IN_MODIFIER);
new_socket.attribute_domain = legacy_socket.attribute_domain;
new_socket.default_attribute_name = BLI_strdup_null(legacy_socket.default_attribute_name);
new_socket.socket_data = legacy_socket.default_value;
new_socket.properties = legacy_socket.prop;
/* Clear moved pointers in legacy data. */
/* The following data are stolen from the old data, the ownership of their memory is directly
* transferred to the new data. */
new_socket.default_attribute_name = legacy_socket.default_attribute_name;
legacy_socket.default_attribute_name = nullptr;
new_socket.socket_data = legacy_socket.default_value;
legacy_socket.default_value = nullptr;
new_socket.properties = legacy_socket.prop;
legacy_socket.prop = nullptr;
/* Unused data */
/* Unused data. */
MEM_delete(legacy_socket.runtime);
legacy_socket.runtime = nullptr;