Fix #108754: remove overactive color management assert
The assert attempted to guard against file formats declaring themselves as "requiring a float buffer" but outputing to a "byte buffer". However, DPX seems to permit this and the code seems to support it correctly. The assert was originally added in 2022 by5baa3ecda6. Subsequently the test which exposed the problem was added in 2023 by7699c7407d. But the issue at hand has existed since DPX was added; it's the only format with this combination of capabilities. Pull Request: https://projects.blender.org/blender/blender/pulls/117914
This commit is contained in:
committed by
Jesse Yurkovich
parent
c174fd4e06
commit
434bb0c93f
@@ -2572,8 +2572,6 @@ ImBuf *IMB_colormanagement_imbuf_for_write(ImBuf *ibuf,
|
||||
* display transform for renders, or a user specified color space for the file. */
|
||||
const bool byte_output = BKE_image_format_is_byte(image_format);
|
||||
|
||||
BLI_assert(!(byte_output && linear_float_output));
|
||||
|
||||
/* If we're saving from RGBA to RGB buffer then it's not so much useful to just ignore alpha --
|
||||
* it leads to bad artifacts especially when saving byte images.
|
||||
*
|
||||
|
||||
Reference in New Issue
Block a user