dillongoostudios/goo-engine
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Memory leak with node interface forward compatibility

Browse Source 
The runtime pointers are allocated when reading sockets,
they have to be freed when the legacy sockets are freed.
This commit is contained in:
Hans Goudey
2023-09-01 15:30:10 -04:00
parent 9fd4091f5b
commit e160a4ceca
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/blender/blenloader/intern/versioning_400.cc
+10 -2
View File
@@ -992,8 +992,16 @@ void blo_do_versions_400(FileData *fd, Library * /*lib*/, Main *bmain)
FOREACH_NODETREE_BEGIN (bmain, ntree, id) {
/* Clear legacy sockets after conversion.
* Internal data pointers have been moved or freed already. */
BLI_freelistN(&ntree->inputs_legacy);
BLI_freelistN(&ntree->outputs_legacy);
LISTBASE_FOREACH_MUTABLE (bNodeSocket *, legacy_socket, &ntree->inputs_legacy) {
MEM_delete(legacy_socket->runtime);
MEM_freeN(legacy_socket);
}
LISTBASE_FOREACH_MUTABLE (bNodeSocket *, legacy_socket, &ntree->outputs_legacy) {
MEM_delete(legacy_socket->runtime);
MEM_freeN(legacy_socket);
}
BLI_listbase_clear(&ntree->inputs_legacy);
BLI_listbase_clear(&ntree->outputs_legacy);
}
FOREACH_NODETREE_END;
}